clairemcginty opened a new pull request, #39645: URL: https://github.com/apache/beam/pull/39645
I discovered when testing a snapshot of https://github.com/apache/beam/pull/39250 that _some properties_, like bloom filter enabling, were getting propagated, but non-Parquet-related properties, like `write.data.path`, were not. Root cause: writeProperties passed via `IcebergIO.writeRows().withWriteProperties(...)` were only forwarded to `Parquet.DataWriteBuilder.setAll()` in RecordWriter, but were never stored as Iceberg table properties. This means: - Parquet-level properties (e.g., write.parquet.bloom-filter-enabled.column.*) happened to work, because Iceberg's Parquet.WriteBuilder parses them from its internal config map (https://github.com/apache/iceberg/blob/main/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java#L650-L668) regardless of whether they came from table.properties() or a direct setAll() call. - Table-level properties (e.g., write.data.path, write.metadata.*) did not work, because they're read from table.properties() by Iceberg's LocationProvider and metadata machinery, not from the Parquet builder's config map. It turns out that Iceberg's forTable(table) (https://github.com/apache/iceberg/blob/main/parquet/src/main/java/org/apache/iceberg/parquet/Parquet.java#L905-L911) already calls setAll(table.properties()), loading all table properties into the builder's config. So the correct place to apply writeProperties is on the table itself, not as a second setAll() on the builder. This PR merges `writeProperties` into the table properties at creation time in both `RecordWriterManager.loadOrCreateTable()` and `WritePartitionedRowsToFiles.loadOrCreateTable()`. ------------------------ Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead. - [ ] Update `CHANGES.md` with noteworthy changes. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier). To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md) GitHub Actions Tests Status (on master branch) ------------------------------------------------------------------------------------------------ [](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule) [](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule) See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
