arunpandianp commented on code in PR #39646:
URL: https://github.com/apache/beam/pull/39646#discussion_r3724565001
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -828,6 +829,7 @@ private static ChannelCache createChannelCache(
DataflowWorkerHarnessOptions workerOptions,
ComputationConfig.Fetcher configFetcher,
GrpcDispatcherClient dispatcherClient) {
+ AtomicLong directpathPrimaryNotReadyWaitNanos = new
AtomicLong(TimeUnit.SECONDS.toNanos(15));
Review Comment:
make it a static member of StreamingDataflowWorker? So we can get a hold on
this if needed (eg: to print in status pages).
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/FailoverChannel.java:
##########
@@ -17,6 +17,7 @@
*/
package org.apache.beam.runners.dataflow.worker.windmill.client.grpc.stubs;
+import java.net.http.WebSocket.Listener;
Review Comment:
looks unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
