shunping commented on code in PR #39661: URL: https://github.com/apache/beam/pull/39661#discussion_r3731167695
########## sdks/python/apache_beam/typehints/schemas.py: ########## @@ -1420,6 +1420,7 @@ def argument(self): # TODO: A temporary fix for missing jdbc logical types. # See the discussion in https://github.com/apache/beam/issues/35738 for # more detail. +@LogicalType._register_internal Review Comment: This looks like we are back the problem of registering `MillisInstant`. @Abacn ########## sdks/python/apache_beam/typehints/schemas.py: ########## @@ -1420,6 +1420,7 @@ def argument(self): # TODO: A temporary fix for missing jdbc logical types. # See the discussion in https://github.com/apache/beam/issues/35738 for # more detail. +@LogicalType._register_internal Review Comment: This looks like we are back to the problem of registering `MillisInstant`. @Abacn -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
