Abacn commented on code in PR #39663:
URL: https://github.com/apache/beam/pull/39663#discussion_r3731591386
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/data/BeamFnDataGrpcMultiplexer.java:
##########
@@ -194,6 +206,9 @@ public void close() throws Exception {
outboundObserver.onError(
Status.CANCELLED.withDescription("Multiplexer hanging
up").asException());
inboundObserver.onCompleted();
+ if (channel != null) {
Review Comment:
Thanks. I was hopping the leak could have resolved in #39390, where
BeamFnDataGrpcMultiplexer is closed there. Turns out there are still missing
piece here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
