Abacn commented on code in PR #39461: URL: https://github.com/apache/beam/pull/39461#discussion_r3737820456
########## sdks/python/apache_beam/io/fileio.py: ########## @@ -261,10 +344,11 @@ class MatchContinuously(beam.PTransform): guarantees. Matching continuously scales poorly, as it is stateful, and requires storing - file ids in memory. In addition, because it is memory-only, if a pipeline is - restarted, already processed files will be reprocessed. Consider an alternate - technique, such as Pub/Sub Notifications - (https://cloud.google.com/storage/docs/pubsub-notifications) + file ids for every file the pattern has matched. With ``has_deduplication`` Review Comment: Follow up: now #39090 has been merged. We can introduce an option for FileIO.matchContinuously (timestamp_cursor), if set True, then it's backed by watch transform's timestamp_cursor mode -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
