junaiddshaukat commented on PR #39680: URL: https://github.com/apache/beam/pull/39680#issuecomment-5226002508
> I think we should also add a test (similar to flink and spark), otherwise this LGMT! Added kafka_streams_java_job_server_test.py, following spark_java_job_server_test.py. It covers the job server cache (and that it's keyed only on the two options groups that change the server's configuration), the jar resolution, and the arguments the driver is launched with. I checked the tests actually fail when the code is wrong rather than just passing — dropping the runner options from the cache key breaks the cache test, and pointing the gradle target elsewhere breaks the jar test. One thing I want to check with you: flink and spark also have the runner-level suite (spark_runner_test.py / flink_runner_test.py) that extends PortableRunnerTest. That needs a gradle task, a workflow, and a real broker in CI, so I didn't put it in this PR. Should I file it as a follow-up issue, or do you want it here before merging? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
