aaltay commented on a change in pull request #12894:
URL: https://github.com/apache/beam/pull/12894#discussion_r498582933



##########
File path: website/www/site/content/en/get-started/wordcount-example.md
##########
@@ -1207,7 +1210,7 @@ each element in the `PCollection`.
 {{< /highlight >}}
 
 {{< highlight py >}}
-beam.Map(AddTimestampFn(timestamp_seconds))
+beam.Map(AddTimestampFn(timestamp_seconds_min, timestamp_seconds_max))

Review comment:
       Where is `AddTimestampFn` defined? Java/python/go examples seemed to 
differ.

##########
File path: website/www/site/content/en/get-started/wordcount-example.md
##########
@@ -1061,11 +1061,14 @@ This runner is not yet available for the Python SDK.
 {{< highlight class="runner-dataflow" >}}
 # As part of the initial setup, install Google Cloud Platform specific extra 
components.
 pip install apache-beam[gcp]
-python -m apache_beam.examples.windowed_wordcount --input YOUR_INPUT_FILE \
+python -m apache_beam.examples.windowed_wordcount --input_topic 
projects/YOUR_GCP_PROJECT/topics/YOUR_TOPIC \

Review comment:
       Instructions for `runner-direct` above also needs to be updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to