PDGGK commented on PR #39744: URL: https://github.com/apache/beam/pull/39744#issuecomment-5281881346
The one red check is `beam_PreCommit_Java_IOs_Direct`, and it is a known-flaky JMS test rather than anything from this PR: ``` JmsIOTest > testCheckpointMarkSafety[with client class org.apache.qpid.jms.JmsConnectionFactory] FAILED 70 tests completed, 1 failed > Task :sdks:java:io:jms:test FAILED ``` - #30225 is **still open** and tracks exactly this: *"[Failing Test]: JmsIOTest. testCheckpointMark flaky"*. Its own description cites an example run from "a PR unrelated to Jms". - #26203 (JMS tests flaky due to port occupied) and #36976 (loosening an immediate-advance assertion in the same area) are earlier rounds of the same thing. - This PR changes two files, both `sdks/java/core/.../util/RowJson*`. `grep -rl RowJson sdks/java/io/jms/src` returns nothing, so there is no path from this diff to the JMS reader's checkpoint marks. Everything else is green: 21 passing, 2 skipped. `:sdks:java:core:test --tests '*RowJsonTest*'` is 78/78 locally, and `spotlessCheck` / `checkstyleMain` / `checkstyleTest` pass. Per the bot's instructions, overriding so this can get a look. assign set of reviewers -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
