rwiggles commented on code in PR #39665:
URL: https://github.com/apache/beam/pull/39665#discussion_r3779914643
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/work/processing/failures/WorkFailureProcessor.java:
##########
@@ -166,40 +168,40 @@ private RetryEvaluation evaluateRetry(String
computationId, Work work, Throwable
if (isOutOfMemoryError(parsedException)) {
String heapDump = tryToDumpHeap();
LOG.error(
- "Execution of work for computation '{}' for sharding key '{}' failed
with out-of-memory. "
+ "Execution of work for fused stage '{}' for sharding key '{}' failed
with out-of-memory. "
+ "Work will not be retried locally. Heap dump {}.",
- computationId,
+ systemName,
work.getWorkItem().getShardingKey(),
heapDump,
parsedException);
return RetryEvaluation.RETHROW_THROWABLE;
}
- if (!failureTracker.trackFailure(computationId, work.getWorkItem(),
parsedException)) {
+ if (!failureTracker.trackFailure(systemName, work.getWorkItem(),
parsedException)) {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
