junaiddshaukat commented on PR #39762:
URL: https://github.com/apache/beam/pull/39762#issuecomment-5306870154

   > LGTM, can we please rebase this on 
`feat/18479-kafka-streams-runner-skeleton` so that it can be merge 
independently on the previous PR [#39761 
(review)](https://github.com/apache/beam/pull/39761#pullrequestreview-4945740560)?
   
   Rebased onto feat/18479-kafka-streams-runner-skeleton, so it is one commit 
and can merge independently of #39761.
   
   I checked the gate still holds after the rebase: ./gradlew projects shows no 
Kafka Streams projects, and with -Pwith-kafka-streams-runner it shows all three.
   
   One check on this PR fails and I do not think it is the change. 
beam_PreCommit_Yaml_Xlang_Direct dies in "Setup environment" with the action 
gradle/actions/setup-gradle is not allowed in apache/beam. It passes on master 
and fails only on my fork branch, and this PR triggers it because it touches 
the root build files. Looks like the actions allowlist for fork PRs, but you 
can see more than I can there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to