junaiddshaukat opened a new pull request, #39781: URL: https://github.com/apache/beam/pull/39781
Part of #18479. The changes that were sitting on the master merge, moved onto the feature branch so the merge to master can come from the branch itself. Two of them are CI fixes the feature branch never exercised, because its own workflow only built the runner. RAT rejects the measurement `docker-compose.yml` for having no Apache license header, and yapf wants one line in the Python wrapper joined. The rest is shortening the explanation comments. Measured against the other runners, comment lines as a fraction of code were 33% here against 17% for core-java, 14% for Spark, 12% for direct-java and 9% for Flink, and long blocks were about three times as frequent per file as the worst of those. This takes it to 29% and cuts the longest block from 52 lines to 36; the worst class comments are rewritten and the reasoning kept. It also corrects four comments that had gone stale: two translators claiming topics are not created automatically, though `KafkaStreamsTopicManager` has created them for months; `KStreamsPayload` saying its serde does not exist yet; and `ReadTranslator` pointing at the test runner for a conversion the runner now does itself. Verified with `./gradlew -Pwith-kafka-streams-runner :runners:kafka-streams:build`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
