shunping commented on PR #39806: URL: https://github.com/apache/beam/pull/39806#issuecomment-5332996340
This PR does not change the location of `GcpSecret` and `GcpHsmGeneratedSecret`: they were placed under sdks/java/core because they are used by GBEK. This added the dependency of gcp secret manager in https://github.com/apache/beam/blob/master/sdks/java/core/build.gradle#L110 However, it may not be the ideal place, especially if we want to support other secret managers like AWS or Azure later. For those, we might want to put them under their individual io folder/package: https://github.com/apache/beam/tree/master/sdks/java/io/amazon-web-services2/src/main/java/org/apache/beam/sdk/io/aws2 and https://github.com/apache/beam/tree/master/sdks/java/io/azure/src/main/java/org/apache/beam/sdk/io/azure. For GCP secret manager, it is currently integrated in GBEK, but we may also want to move it to some place like: https://github.com/apache/beam/tree/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp in the future. WDYT? @damccorm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
