parveensania commented on code in PR #39646:
URL: https://github.com/apache/beam/pull/39646#discussion_r3807869864
##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/stubs/FailoverChannelTest.java:
##########
@@ -283,11 +284,110 @@ public void testStateFallbackAfterPrimaryNotReady() {
// Within 10 seconds: grace period not elapsed, routes to primary.
failoverChannel.newCall(methodDescriptor, CallOptions.DEFAULT);
verify(mockChannel).newCall(any(), any());
+ // Fallback must not have been used yet.
+ verify(mockFallbackChannel, never()).newCall(any(), any());
// After 10 seconds: routes to fallback.
time.addAndGet(TimeUnit.SECONDS.toNanos(11));
failoverChannel.newCall(methodDescriptor, CallOptions.DEFAULT);
verify(mockFallbackChannel).newCall(any(), any());
+ // Primary must not have been used for this call (still only 1 invocation).
+ verify(mockChannel, org.mockito.Mockito.times(1)).newCall(any(), any());
Review Comment:
Done
##########
runners/google-cloud-dataflow-java/worker/windmill/src/main/proto/windmill.proto:
##########
@@ -1018,6 +1018,10 @@ message UserWorkerRunnerV1Settings {
optional int64 max_cached_entry_bytes = 5 [default = -1];
+ // Time to wait before switching to fallback connectivity if primary is not
ready.
+ // Only used if direcpath is enabled for the job. Default is 15 seconds.
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
