Abacn commented on code in PR #39818:
URL: https://github.com/apache/beam/pull/39818#discussion_r3814008175


##########
sdks/python/apache_beam/yaml/standard_io.yaml:
##########
@@ -183,6 +183,34 @@
   config:
     gradle_target: 'sdks:java:extensions:schemaio-expansion-service:shadowJar'
 
+# JMS

Review Comment:
   JmsIO uses user provided client. Beam's messaging-expansion-service shades 
activeMQ provider, but we should support user provided client. In 
xlang_jsmio_it_test it used IBM MQ as an example. Consider support 
'ReadFromIbmMQ' and 'WriteToIbmMQ' here, by configuring `classpath=[
                   'com.ibm.mq:com.ibm.mq.allclient:9.3.0.25',
                   'org.json:json:20251224']`
   
   I'm not sure if Beam YAML's `config:` supports pluggable classpath, it 
should do.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to