ulofiai opened a new pull request, #39819:
URL: https://github.com/apache/beam/pull/39819

   Fixes #18194.
   
   The shared `jacocoTestReport` configuration in `BeamModulePlugin` hard-codes 
its execution data to `build/jacoco/test.exec`. Any other `Test` task that runs 
in a module writes its JaCoCo execution data to `build/jacoco/<taskName>.exec` 
(Gradle default), and that data was silently excluded from the report. In 
particular, `runners/direct-java`'s `needsRunnerTests` and `validatesRunner` 
tasks execute the `sdks/java/core` `NeedsRunner`/`ValidatesRunner` suites, and 
none of that coverage was counted — the under-reporting described in the issue 
(the bulk of the SDK is tested via the DirectRunner).
   
   This change sets the report's execution data to a `fileTree` over 
`build/jacoco/*.exec`, so execution data from every `Test` task that actually 
ran in the module is aggregated. A `fileTree` is also more robust than a 
hard-coded file reference when a given exec file does not exist (the report 
task is skipped as NO-SOURCE instead of failing). Report class directories, 
source directories, excludes, and the CI upload path 
(`**/build/jacoco/report/**`) are unchanged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to