ahmedabu98 commented on code in PR #39597:
URL: https://github.com/apache/beam/pull/39597#discussion_r3816236774


##########
sdks/java/io/iceberg/src/test/java/org/apache/beam/sdk/io/iceberg/BigQueryManagedTableCrossEngineIT.java:
##########
@@ -136,24 +137,47 @@ public void testManagedIcebergReadByThreePartName() 
throws IOException {
             .put(
                 "catalog_properties",
                 ImmutableMap.<String, String>builder()
-                    .put("gcp_project", PROJECT)
-                    .put("gcp_location", connectionLocation())
-                    .put("warehouse", STORAGE_URI_ROOT)
-                    .put("catalog-impl", 
"org.apache.iceberg.gcp.bigquery.BigQueryMetastoreCatalog")
+                    .put("type", "rest")
+                    .put("uri", 
"https://biglake.googleapis.com/iceberg/v1/restcatalog";)
+                    .put(
+                        "warehouse",
+                        String.format(
+                            "bq://projects/%s/locations/%s", PROJECT, 
connectionLocation()))
+                    .put("header.x-goog-user-project", PROJECT)
+                    .put("rest-metrics-reporting-enabled", "false")
                     .put("io-impl", "org.apache.iceberg.gcp.gcs.GCSFileIO")
+                    .put("rest.auth.type", 
"org.apache.iceberg.gcp.auth.GoogleAuthManager")

Review Comment:
   Ok cool what you have there should work as-is because you exported the 
metadata



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to