f-loris commented on PR #39793: URL: https://github.com/apache/beam/pull/39793#issuecomment-5354423138
@Abacn Thanks, all four addressed in my recent commit. - @SuppressWarnings: removed. The only raw declarations were in the private createSideInputReader, so I dropped it and made ParDoTranslatorBatch's version static on TranslationState, like skipUnconsumedOutputs/tagsColumnIndex which this translator already reuses. -createEncoders: used the array form, now a single static shared by both translators (ParDoTranslatorBatch's copy had the same issue). new Encoder[n] does emit [rawtypes] and the module builds with -Xlint:all -Werror, so it carries a method-scoped suppression instead of the class-level one. - Special case: comment added at the dispatch site. - @NonNull: dropped. Happy to do the capability-matrix update as a follow-up once released. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
