kennknowles commented on code in PR #39807:
URL: https://github.com/apache/beam/pull/39807#discussion_r3857674961
##########
runners/core-java/src/main/java/org/apache/beam/runners/core/triggers/TriggerStateMachine.java:
##########
@@ -346,8 +351,8 @@ public void clear(TriggerContext c) throws Exception {
}
}
- public Iterable<TriggerStateMachine> subTriggers() {
- return subTriggers;
+ public List<TriggerStateMachine> subTriggers() {
Review Comment:
It is not necessary, but it is always actually a finite list and it makes
other code cleaner (not using `Iterables.get` for scanning). Most accesses are
by index, so it is really a better type. This is not actually end-user public
code, but just used by runners. I could switch it to iterable easily (I tested)
but I think it is better as List actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
