damccorm commented on code in PR #39887:
URL: https://github.com/apache/beam/pull/39887#discussion_r3883792864
##########
it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/pubsub/PubsubResourceManager.java:
##########
@@ -283,7 +283,11 @@ public String createSchema(
ProjectName.newBuilder().setProject(projectId).build(),
Schema.newBuilder().setType(schemaType).setDefinition(schemaDefinition).build(),
"schema-" + testId + "-" + schemaTopic.getTopic());
- createdSchemas.add(SchemaName.parse(schema.getName()));
+ SchemaName schemaName = SchemaName.parse(schema.getName());
+ if (schemaName == null) {
+ return null;
Review Comment:
This should never happen, right? Should this just be a runtime error because
we failed to create a schema?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
