chadrik commented on a change in pull request #13004:
URL: https://github.com/apache/beam/pull/13004#discussion_r499055080
##########
File path: sdks/python/apache_beam/transforms/combiners_test.py
##########
@@ -416,7 +416,7 @@ def test_tuple_combine_fn_without_defaults(self):
max).with_common_input()).without_defaults())
assert_that(result, equal_to([(1, 7.0 / 4, 3)]))
- def test_to_list_and_to_dict(self):
Review comment:
I split these into two tests to avoid overwriting the same variable with
different types, and it seemed better to test smaller units, regardless
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
