Abacn commented on code in PR #39916:
URL: https://github.com/apache/beam/pull/39916#discussion_r3896811815
##########
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/artifact/ArtifactStagingService.java:
##########
@@ -510,6 +515,9 @@ private String createFilename(String environment,
RunnerApi.ArtifactInformation
// all path separators.
List<String> components =
Splitter.onPattern("[^A-Za-z-_.]]").splitToList(path);
String base = components.get(components.size() - 1);
+ if (IS_OS_WINDOWS) {
+ environment =
WINDOWS_INVALID_CHARS.matcher(environment).replaceAll("_");
Review Comment:
Still allow non-ascii chars as before while fixed regex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
