reuvenlax commented on PR #39619: URL: https://github.com/apache/beam/pull/39619#issuecomment-5513701886
I want to be cautious here, since I'm not convinced that the codegen didn't do anything. The savings here are all on worker startup time, which is generally slow for other reason as well. On Wed, Sep 2, 2026 at 10:22 AM Kenn Knowles ***@***.***> wrote: > *kennknowles* left a comment (apache/beam#39619) > <https://github.com/apache/beam/pull/39619#issuecomment-5513550447> > > interesting! So we were doing code gen that didn't actually specialize the > code to the purpose being generated for? This is definitely a nice > simplification if all that codegen doesn't really do anything. I wonder if > there are opportunities to make the codegen actually do what it is meant to > do... be very specialized straight-line inline-method-call kind of code > that just encodes exactly the thing it is supposed to. > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/39619?email_source=notifications&email_token=AFAYJVJ2MMYNJWNKRWGGVOT5NBJOVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNJRGM2TKMBUGQ32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-5513550447>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AFAYJVKLLUY5RILKHJMPDQT5NBJOVAVCNFSNUABEKJSXA33TNF2G64TZHM2TAOJQGQZDINJ3JFZXG5LFHM2TANRVGEYTGMZXGKQXMAQ> > . > Triage notifications, keep track of coding agent tasks and review pull > requests on the go with GitHub Mobile for iOS > <https://github.com/notifications/mobile/ios/AFAYJVKLXCXDWANZDBWONVD5NBJOVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNJRGM2TKMBUGQ32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y> > and Android > <https://github.com/notifications/mobile/android/AFAYJVOB5LORXO2UAFAI3KL5NBJOVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKNJRGM2TKMBUGQ32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>. > Download it today! > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
