i05nagai commented on code in PR #39389:
URL: https://github.com/apache/beam/pull/39389#discussion_r3938963810
##########
sdks/go/test/integration/integration.go:
##########
@@ -200,7 +200,7 @@ var flinkFilters = []string{
"TestTestStreamTimersEventTime",
"TestTimers_EventTime_WithNoOutputTimestamp", // Encounter error:
TimestampCombiner moved element from TIMESTAMP_MAX_VALUE to earlier time (end
of global window) for window GlobalWindow
- "TestTimers_ProcessingTime.*", // Flink doesn't support processing
time timers.
+ "TestTimers_ProcessingTime.*", // Flink doesn't support
processing time timers.
Review Comment:
Thank you for reviewing!
I ran go fmt against this file. The formatting matches go fmt.
As far as I can tell, `go fmt` runs only against `sdks/go/pkg/beam` in CI:
https://github.com/apache/beam/blob/master/.github/workflows/go_tests.yml#L61
I can do either
* (1) Revert this formatting
* (2) Or create another issue and a dedicated PR to update the go fmt check
to include all Go files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
