je-ik commented on PR #39783:
URL: https://github.com/apache/beam/pull/39783#issuecomment-5584620820
Thanks for the contribution!
> Testing: FlinkStateInternalsTest — existing ordered-list tests cover
ordering semantics; they pass unchanged since the multimap flattens back to the
same sorted order. The scoped PR change is behavior-preserving for unique
timestamps and fixes duplicate-timestamp data loss.
I think it would be good to add tests that specifically test that if there
are items with identical timestamps, these are preserved. There could be two
places where add it:
a) in FlinkRunner (that would cover the changes in this PR)
b) ParDoTest.java (in java-core) that would be used in ValidatesRunner
suite to check all the rest of runners pass it (this would be ideally added in
different PR so that this one is not blocked if there are any issues found).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
