Abacn commented on code in PR #39941:
URL: https://github.com/apache/beam/pull/39941#discussion_r3960909567
##########
sdks/python/setup.py:
##########
@@ -535,6 +535,7 @@ def get_portability_package_data():
# errors raised during async flushes instead of swallowing them.
'google-cloud-bigtable>=2.42.0,<3',
'google-cloud-build>=3.35.0,<4',
+ 'google-cloud-firestore>=2.0.0,<3',
Review Comment:
`beam[gcp]` depends on bigtable/spanner because Python SDK has native
BigtableIO and SpannerIO (the latter is subject for removal though).
I think we can create a "gcp_test" extra and add it to "beamPythonExtra"
https://github.com/apache/beam/blob/6a0bd90065ac35b70fc9888055319593b392a9fc/.github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml#L85
here
In the future we may remove spanner dependency from `[gcp]` and also other
test only dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
