Abacn commented on PR #40096: URL: https://github.com/apache/beam/pull/40096#issuecomment-5624490049
> > Batch persistent state updates into a single commit and push per workflow execution instead of committing on every file write. > > I think I didn't do this because it increases the chances of conflicts and the impact of them (e.g. if multiple files should've been written to) I did this because I realize we commit multiple times during a single run of the workflow, e.g. in processNewPrs.ts, a single PR with 2 labels triggers 3 separate commits (writePrState + 2 $\times$ writeReviewersForLabelState) seconds apart. We now record a timestamp on PR creation and will make it worse. To avoid merge conflict we can add the 3 pr-bot workflow into a concurrency_group (pr-bot-prs-needing-attention.yml, pr-bot-pr-updates.yml, pr-bot-new-prs.yml). Checking running history all of them are running for 1-2 minutes. If number of PR comments is less than "~50" per hour it's managable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
