stankiewicz commented on code in PR #40022:
URL: https://github.com/apache/beam/pull/40022#discussion_r3989063541
##########
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/LatestFnTest.java:
##########
@@ -100,14 +100,14 @@ public void testAddInputSameTimestamp() {
@Test
public void testAddInputNullAccumulator() {
- thrown.expect(NullPointerException.class);
+ thrown.expect(IllegalArgumentException.class);
thrown.expectMessage("accumulator");
fn.addInput(null, TV);
}
@Test
public void testAddInputNullInput() {
- thrown.expect(NullPointerException.class);
+ thrown.expect(IllegalArgumentException.class);
Review Comment:
moving away from
org.apache.beam.vendor.guava.v32_1_2_jre.com.google.common.base.Preconditions.checkNotNull;
to org.apache.beam.sdk.util.Preconditions.checkArgumentNotNull changes
exception thrown, I'm curious if this is intended. It's not something someone
would normally catch, just observation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
