arunpandianp commented on code in PR #39961:
URL: https://github.com/apache/beam/pull/39961#discussion_r4001117929


##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/Sink.java:
##########
@@ -36,6 +37,9 @@ public interface SinkWriter<ElemT> extends AutoCloseable {
     /** Adds a value to the sink. Returns the size in bytes of the data 
written. */
     public long add(ElemT value) throws IOException;
 
+    /** Called when all elements for a specific key have been processed. */

Review Comment:
   This is called in streaming for all jobs. Batch does not call. Updated 
comment to say this is called only for streaming.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to