kennknowles commented on code in PR #36296:
URL: https://github.com/apache/beam/pull/36296#discussion_r4006937267
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/WriteRename.java:
##########
@@ -329,14 +331,39 @@ private BigQueryHelpers.PendingJob startCopy(
new EncryptionConfiguration().setKmsKeyName(kmsKey));
}
- String bqLocation =
- BigQueryHelpers.getDatasetLocation(
- datasetService, ref.getProjectId(), ref.getDatasetId());
+ String bqLocation;
+ try {
Review Comment:
It looks the same - did you not push the change?
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/UpdateSchemaDestination.java:
##########
@@ -302,9 +302,14 @@ private BigQueryHelpers.PendingJob startZeroLoadJob(
loadJobProjectId == null || loadJobProjectId.get() == null
? tableReference.getProjectId()
: loadJobProjectId.get();
- String bqLocation =
- BigQueryHelpers.getDatasetLocation(
- datasetService, tableReference.getProjectId(),
tableReference.getDatasetId());
+ String bqLocation;
+ try {
+ bqLocation =
+ BigQueryHelpers.getDatasetLocation(
+ datasetService, tableReference.getProjectId(),
tableReference.getDatasetId());
+ } catch (IOException | InterruptedException e) {
+ throw new RuntimeException(e);
Review Comment:
You need to reset `Thread.currentThread().interrupt();` I believe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
