aIbrahiim commented on code in PR #40040:
URL: https://github.com/apache/beam/pull/40040#discussion_r4017820108
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/SpannerChangestreamsReadSchemaTransformProvider.java:
##########
@@ -304,42 +299,17 @@ public void finish(FinishBundleContext c) {
}
}
- private static final HashMap<String, SpannerSchema> TABLE_SCHEMAS = new
HashMap<>();
-
private static Schema getTableSchema(SpannerChangestreamsReadConfiguration
config) {
- Pipeline miniPipeline = Pipeline.create();
Review Comment:
ok and yes both still need Spanner access at expansion and submission time
I'll create a follow up issue to allow an optional schema config on the
Spanner CDC SchemaTransform so expansion can skip live information_schema
access when the schema is provided
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
