jrmccluskey commented on code in PR #40082: URL: https://github.com/apache/beam/pull/40082#discussion_r4017127753
########## sdks/python/apache_beam/io/gcp/internal/clients/bigquery/__init__.py: ########## @@ -28,6 +29,9 @@ from apache_beam.io.gcp.internal.clients.bigquery.bigquery_v2_client import * from apache_beam.io.gcp.internal.clients.bigquery.bigquery_v2_messages import * except ImportError: + logging.warning( + "apitools not found, and bigquery client libraries are not " + "available despite the import not raising an ImportError.") Review Comment: As best I can tell, this was hand-waved away in order to avoid import errors breaking unit tests (a fun side effect of apitools being a required dependency for all of these generated clients.) Less blast radius to just throw this warning here, mainly to make debugging unit tests easier while I migrate things over -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
