jrmccluskey commented on code in PR #40080:
URL: https://github.com/apache/beam/pull/40080#discussion_r4020300968
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AssignDestinationsAndPartitions.java:
##########
@@ -111,58 +139,83 @@ public void processElement(
dynamicDestinations.getTableStringIdentifier(
ValueInSingleWindow.of(element, timestamp, window, paneInfo));
+ String canonicalTableId;
+ try {
+ canonicalTableId =
+ IcebergUtils.tableIdentifierToString(
+ IcebergUtils.parseTableIdentifier(tableIdentifier));
+ } catch (Exception e) {
+ canonicalTableId = tableIdentifier.trim();
+ }
Review Comment:
Okay yeah this is unnecessary. It only makes changes if, for some reason,
the underlying table identifiers being passed aren't formatted correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
