shunping commented on code in PR #40081:
URL: https://github.com/apache/beam/pull/40081#discussion_r4026680051
##########
sdks/python/apache_beam/typehints/native_type_compatibility.py:
##########
@@ -125,14 +125,16 @@ def _safe_issubclass(derived, parent):
issubclass(derived, parent), or False if a TypeError was raised.
"""
try:
- return issubclass(derived, parent)
+ if issubclass(derived, parent):
Review Comment:
How about a TODO here so we can revisit this logic once the Beam minimum
python version passes 3.12?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
