CarloMariaProietti opened a new pull request, #40149:
URL: https://github.com/apache/beam/pull/40149
**Please** add a meaningful description for your change here
------------------------
Fixes #39991
Problem:
The BufferingDoFnRunner class has the following issue: the
minBufferedElementTimestamp field is intended to hold the minimum timestamp
among all elements in currentBufferingElementsHandler. This semantic contract
can be observed in the processElement and onTimer methods. However,
checkpointCompleted violates this contract by setting
minBufferedElementTimestamp to Long.MAX_VALUE without guaranteeing that
currentBufferingElementsHandler is completely empty (while likely, it is not
guaranteed; see #39991 for details).
Solution:
checkpointCompleted now sets minBufferedElementTimestamp to Long.MAX_VALUE
only if currentBufferingElementsHandler is empty; otherwise, it recomputes the
minimum timestamp according to its semantic invariant.
Implementation Details:
Implemented following the GRASP Polymorphism pattern. The semantics across
implementations of the polymorphic getTimestamp method remain consistent with
processElement and onTimer.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
