Eliaaazzz opened a new pull request, #40155:
URL: https://github.com/apache/beam/pull/40155
Part of #39684, and the Go side of #19817. Depends on #40154 (the first
three commits); review the last commit.
Both types have a wire encoding that differs from the row encoding of their
representation type, so they use `schema.RegisterLogicalTypeCoder`:
- `schema.MillisInstant` (`beam:logical_type:millis_instant:v1`), a
`time.Time` with millisecond precision. The representation is INT64, but Java
(`InstantCoder`) and Python (`TimestampCoder`, special cased in `row_coder.py`)
encode it as 8 big endian bytes shifted by the minimum int64, so the byte order
matches the chronological order. The Go encoding uses the same shift as
`coder.EncodeEventTime`. Encoding a value with sub millisecond precision
returns an error.
- `schema.Decimal` (`beam:logical_type:decimal:v1`), an arbitrary precision
decimal with `Unscaled *big.Int` and `Scale int32`. The representation is
BYTES, encoded as Java's `BigDecimalCoder` and Python's `DecimalCoder` do: the
scale as a varint followed by the length prefixed two's complement bytes of the
unscaled value. `ParseDecimal` and `String` convert to and from plain notation.
The `millis_instant` and `decimal` cases of standard_coders.yaml now run in
the Go regression test.
Tests: byte level row encoding against the yaml examples for both types
(including the negative decimal and the shifted millis value), two's complement
conversion at the byte boundaries, decimal parsing and formatting, and the sub
millisecond error.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
