jrmccluskey commented on code in PR #40140:
URL: https://github.com/apache/beam/pull/40140#discussion_r4038079768
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/IcebergIO.java:
##########
@@ -549,6 +649,33 @@ public IcebergWriteResult expand(PCollection<Row> input) {
"Must only provide direct write limit for unbounded pipelines.");
}
+ boolean isStreaming = IcebergUtils.isUnbounded(input);
+
+ if (getUsingSideInputTableCache() && isStreaming &&
getMaximumCacheSize() != null) {
+ throw new IllegalArgumentException(
+ "maximumCacheSize is currently not supported for unbounded
streaming pipelines.");
+ }
Review Comment:
Yeah this wound up being unnecessary input validation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
