Eliaaazzz opened a new pull request, #40156:
URL: https://github.com/apache/beam/pull/40156
Part of #39684, the Go side of #23526. Depends on #40155 (the first four
commits); review the last commit.
`beam:logical_type:fixed_char:v1`, `var_char:v1`, `fixed_bytes:v1` and
`var_bytes:v1` are STRING and BYTES on the wire; their INT32 argument is the
fixed or maximum length. The Go row coder is built from the Go type alone, so a
plain `string` or `[]byte` field is the natural Go representation, and it must
keep producing an atomic STRING or BYTES schema field.
- `schema.RegisterPassThroughLogicalType(urn, goType)` maps a URN to the Go
type of its representation without mapping that Go type back. A schema field
with the URN decodes with the plain row encoding of the Go type, and the
argument is ignored (the length is not enforced). Any argument matches because
the arguments PR falls back to the registration without an argument.
- The four standard types are registered this way with `string` and
`[]byte`, so a JDBC or SQL row from Java with CHAR, VARCHAR, BINARY or
VARBINARY columns maps to `string` and `[]byte` fields (nullable columns map to
pointers).
- The char, varchar, binary and varbinary case of standard_coders.yaml now
runs in the Go regression test.
Tests: `ToType` of the yaml schema gives `*string` and `*[]byte` fields,
decoding the yaml example with nulls, and plain `string` and `[]byte` fields
still produce atomic schema fields.
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example:
`addresses #123`), if applicable. This will automatically add a link to the
pull request in the issue. If you would like the issue to automatically close
on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [x] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit
[https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more
information about GitHub Actions CI or the [workflows
README](https://github.com/apache/beam/blob/master/.github/workflows/README.md)
to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
