ngibanel commented on PR #40108: URL: https://github.com/apache/beam/pull/40108#issuecomment-5717344328
@stankiewicz I pushed a rework that supports all property types except SDTMap and SDTStream. Some remarks : 1. I did not use the @AutoOneOf pattern because it breaks Beam schema inference. 2. Instead of throwing an exception for unsupported SDTMap and SDTStream properties, I chose to ignore those properties. I think it would be too restrictive to block the consumption of a message simply because it contains properties using Solace-specific types. This is a known and intentional limitation of the connector, and in any case, interoperability for these types is not supported by Solace. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
