Abacn commented on code in PR #40152:
URL: https://github.com/apache/beam/pull/40152#discussion_r4039286582
##########
sdks/go/pkg/beam/core/graph/coder/row_decoder.go:
##########
@@ -341,10 +359,14 @@ func (b *RowDecoderBuilder) decoderForSingleTypeReflect(t
reflect.Type) (typeDec
return typeDecoderFieldReflect{decode: reflectDecodeByte}, nil
case reflect.String:
return typeDecoderFieldReflect{decode: reflectDecodeString}, nil
- case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32,
reflect.Int64:
+ case reflect.Int, reflect.Int8, reflect.Int32, reflect.Int64:
Review Comment:
~Int8 (BYTE) likely has similar inconsistency. Consider a same fix here, or
could be a follow up~
edit: It's fine: BYTE is backed by uint8. See
https://github.com/Eliaaazzz/beam/blob/15745eb513417942b6cfe563961edb508804bd8a/sdks/go/pkg/beam/core/runtime/graphx/schema/schema.go#L658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
