nitinware commented on code in PR #40146:
URL: https://github.com/apache/beam/pull/40146#discussion_r4043455861
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtilV1.java:
##########
@@ -828,6 +841,9 @@ void verifyBucketAccessible(GcsPath path, BackOff backoff,
Sleeper sleeper) thro
getBucket(path, backoff, sleeper);
}
+ // AccessDeniedException permits a null "other" argument and these
exceptions permit a null detail
+ // message, but the JDK constructor stubs are not annotated for nullness.
+ @SuppressWarnings("nullness")
Review Comment:
Done. Extracted helper methods for AccessDeniedException,
FileAlreadyExistsException, and FileNotFoundException. This removes the
method-level suppressions and limits each suppression to a single constructor
call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
