shunping commented on code in PR #40142: URL: https://github.com/apache/beam/pull/40142#discussion_r4044021539
########## it/common/src/main/java/org/apache/beam/it/common/utils/ByteSizeUtils.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.it.common.utils; + +import com.fasterxml.jackson.core.JsonParser; +import com.fasterxml.jackson.core.JsonToken; +import com.fasterxml.jackson.databind.DeserializationContext; +import com.fasterxml.jackson.databind.JsonDeserializer; +import java.io.IOException; +import java.util.Locale; + +/** + * Utilities to read and print byte counts, so that a load test can take a size such as {@code + * "40G"} on its command line and report it back in a human readable form. + */ +public final class ByteSizeUtils { Review Comment: The parsing logic is simplified as we don't have to use regex to support different annotations. And to facilitate future usage, I think extracting the functions to a utility class will improve its reusability. Even though we have more code, it is covered by necessary tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
