christogav commented on code in PR #37991:
URL: https://github.com/apache/beam/pull/37991#discussion_r4062292145
##########
.github/workflows/beam_PreCommit_Go.yml:
##########
@@ -85,8 +85,6 @@ jobs:
with:
java-version: default
go-version: default
- - name: Install Cloud Spanner emulator
Review Comment:
Good question — this was actually a false start on my part. I originally
added the `gcloud components install cloud-spanner-emulator` step because I
assumed the self-hosted runner couldn't pull the emulator's Docker image at
all. Once I dug in further, the real problem was that the image reference was
missing the `gcr.io/` registry prefix, so Docker was resolving it against
Docker Hub (where it doesn't exist) instead of GCR. Fixing the image reference
to `gcr.io/cloud-spanner-emulator/emulator` let us go back to the standard
Docker testcontainers approach (matching how the Mongo IO connector already
does it), so the gcloud component install is no longer needed. This file is now
identical to `master`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
