Abacn commented on code in PR #40205:
URL: https://github.com/apache/beam/pull/40205#discussion_r4064774188
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/fn/splittabledofn/RestrictionTrackers.java:
##########
@@ -102,7 +113,7 @@ public void checkDone() throws IllegalStateException {
try {
delegate.checkDone();
} finally {
- lock.unlock();
+ unlock();
Review Comment:
Do all 4 occurrences of `lock.unlock() -> updateProgressAndUnlock();`
changes really need to update the progress cache inside the lock block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
