tianz101 commented on code in PR #40209:
URL: https://github.com/apache/beam/pull/40209#discussion_r4066854695
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/QueryChangeStreamAction.java:
##########
@@ -355,12 +363,23 @@ public ProcessContinuation run(
}
LOG.debug(
- "[{}] change stream completed successfully up to {}", token,
changeStreamQueryEndTimestamp);
+ "[{}] change stream completed successfully up to {} (last processed
timestamp: {})",
+ token,
+ changeStreamQueryEndTimestamp,
+ lastProcessedTimestamp);
if (!stopAfterQuerySucceeds) {
- // Records stopped being returned for the query due to our artificial
query end timestamp but
- // we want to continue processing the partition, resuming from
changeStreamQueryEndTimestamp.
- if (!tracker.tryClaim(changeStreamQueryEndTimestamp)) {
+ if (isBoundedRestriction) {
Review Comment:
Just want to confirm: if it is bounded, it behaves the same as before.
The workaround fix only affectes unbounded pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
