Abacn commented on code in PR #40181:
URL: https://github.com/apache/beam/pull/40181#discussion_r4073727211
##########
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaReadSchemaTransformConfiguration.java:
##########
@@ -198,6 +198,21 @@ public static Builder builder() {
@Nullable
public abstract Boolean getRedistributeByRecordKey();
+ @SchemaFieldDescription(
+ "Whether to use Google Cloud Platform Application Default Credentials
(ADC) for"
+ + " authenticating with a Google Managed Kafka cluster.")
+ @SchemaFieldNumber("17")
+ @Nullable
+ public abstract Boolean getWithGcpAdc();
Review Comment:
Understand. Since this is mostly a ease-of-use change (users can current set
GCP configs themselves by adding all needed configurations to config) a simple
name is preferred
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
