damccorm commented on code in PR #40207:
URL: https://github.com/apache/beam/pull/40207#discussion_r4075820973
##########
it/google-cloud-platform/build.gradle:
##########
@@ -84,10 +84,13 @@ tasks.register(
+ System.properties
)
tasks.register(
- "BigTablePerformanceTest",
IoPerformanceTestUtilities.IoPerformanceTest, project, 'google-cloud-platform',
'BigTableIOLT',
+ "BigtablePerformanceTest",
IoPerformanceTestUtilities.IoPerformanceTest, project, 'google-cloud-platform',
'BigtableIOLT',
['configuration':'large', 'project':'apache-beam-testing',
'artifactBucket':'io-performance-temp']
+ System.properties
)
+tasks.register("BigTablePerformanceTest") {
+ dependsOn("BigtablePerformanceTest")
+}
Review Comment:
Why do we need these? Aren't we changing the caller?
Same comment as before, lets not take on complexity for this change.
##########
it/build.gradle:
##########
@@ -28,6 +28,10 @@ tasks.register('GCSPerformanceTest') {
dependsOn(":it:google-cloud-platform:GCSPerformanceTest")
}
+tasks.register('BigtablePerformanceTest') {
+ dependsOn(":it:google-cloud-platform:BigtablePerformanceTest")
+}
Review Comment:
Same thing here, lets not take on complexity
##########
sdks/python/apache_beam/io/gcp/bigtableio.py:
##########
@@ -68,10 +68,10 @@
_LOGGER.warning(
'ImportError: from google.cloud.bigtable import Client', exc_info=True)
-__all__ = ['WriteToBigTable', 'ReadFromBigtable']
+__all__ = ['WriteToBigtable', 'ReadFromBigtable']
Review Comment:
I believe changing this also breaks compatibility.
##########
sdks/python/apache_beam/transforms/enrichment_handlers/bigtable.py:
##########
@@ -30,6 +30,7 @@
from apache_beam.transforms.enrichment_handlers.utils import ExceptionLevel
__all__ = [
+ 'BigtableEnrichmentHandler',
Review Comment:
Same thing, lets not add complexity. I also think these changes will show up
as double entries on the pydoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
