ahmedabu98 commented on code in PR #40167:
URL: https://github.com/apache/beam/pull/40167#discussion_r4075955339
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFilesSchemaTransformProvider.java:
##########
@@ -145,6 +146,19 @@ public static Builder builder() {
+ " Requires schema_evolution_options.")
public abstract @Nullable List<String> getRequiredColumns();
+ @SchemaFieldDescription(
+ "When true, nothing is committed or registered: the transform reads
the files' schemas"
+ + " and emits a dry_run_report output with one row that describes
what a real run"
Review Comment:
```suggestion
+ " and emits a `dry_run_report` output with one row that
describes what a real run"
```
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFilesSchemaTransformProvider.java:
##########
@@ -145,6 +146,19 @@ public static Builder builder() {
+ " Requires schema_evolution_options.")
public abstract @Nullable List<String> getRequiredColumns();
+ @SchemaFieldDescription(
+ "When true, nothing is committed or registered: the transform reads
the files' schemas"
+ + " and emits a dry_run_report output with one row that describes
what a real run"
+ + " would do. Its allowed field is true when every file schema can
be merged and the"
+ + " configuration raises no problem; otherwise its reason field
says what a real run"
+ + " would do about it (fail, or route the files to the error
output). Its schemas"
Review Comment:
```suggestion
+ " would do about it (fail, or route the files to the error
output). Its `schemas`"
```
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFilesSchemaTransformProvider.java:
##########
@@ -145,6 +146,19 @@ public static Builder builder() {
+ " Requires schema_evolution_options.")
public abstract @Nullable List<String> getRequiredColumns();
+ @SchemaFieldDescription(
+ "When true, nothing is committed or registered: the transform reads
the files' schemas"
+ + " and emits a dry_run_report output with one row that describes
what a real run"
+ + " would do. Its allowed field is true when every file schema can
be merged and the"
Review Comment:
```suggestion
+ " would do. Its `allowed` field is true when every file schema
can be merged and the"
```
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFilesSchemaTransformProvider.java:
##########
@@ -145,6 +146,19 @@ public static Builder builder() {
+ " Requires schema_evolution_options.")
public abstract @Nullable List<String> getRequiredColumns();
+ @SchemaFieldDescription(
+ "When true, nothing is committed or registered: the transform reads
the files' schemas"
+ + " and emits a dry_run_report output with one row that describes
what a real run"
+ + " would do. Its allowed field is true when every file schema can
be merged and the"
+ + " configuration raises no problem; otherwise its reason field
says what a real run"
Review Comment:
```suggestion
+ " configuration raises no problem; otherwise its `reason`
field says what a real run"
```
##########
sdks/java/io/iceberg/src/main/java/org/apache/beam/sdk/io/iceberg/AddFilesSchemaTransformProvider.java:
##########
@@ -145,6 +146,19 @@ public static Builder builder() {
+ " Requires schema_evolution_options.")
public abstract @Nullable List<String> getRequiredColumns();
+ @SchemaFieldDescription(
+ "When true, nothing is committed or registered: the transform reads
the files' schemas"
+ + " and emits a dry_run_report output with one row that describes
what a real run"
+ + " would do. Its allowed field is true when every file schema can
be merged and the"
+ + " configuration raises no problem; otherwise its reason field
says what a real run"
+ + " would do about it (fail, or route the files to the error
output). Its schemas"
+ + " field lists each distinct file schema with the changes a real
run would make for"
+ + " it and, when it cannot be merged, why. The output only exists
when this is set;"
+ + " consume it as input: <this transform's name>.dry_run_report.
Against a missing"
Review Comment:
```suggestion
+ " consume it as input: `<this transform's
name>.dry_run_report`. Against a missing"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
