ChetanRuparel commented on code in PR #40233:
URL: https://github.com/apache/beam/pull/40233#discussion_r4102290755
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImplTest.java:
##########
@@ -1523,6 +1523,63 @@ public void testInsertTimeoutLog() throws Exception {
verifyWriteMetricWasSet("project", "dataset", "table", " no rows present
in the request. ", 1);
}
+ /**
+ * Tests that {@link DatasetServiceImpl#insertAll} logs and includes
suggested remedy when the
Review Comment:
Done. Added `testExecuteWithRetriesBigQueryNotEnabled` in
`BigQueryServicesImplTest` to verify that `executeWithRetries` fails fast
without retrying, includes both `e.getMessage()` and
`BIGQUERY_NOT_ENABLED_GUIDANCE` in the thrown `IOException`, and omits the
caller's `"aborting after 9 retries."` message.
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
