Abacn commented on code in PR #40321:
URL: https://github.com/apache/beam/pull/40321#discussion_r4126489904
##########
runners/google-cloud-dataflow-java/src/test/java/org/apache/beam/runners/dataflow/TestDataflowRunnerTest.java:
##########
@@ -102,6 +102,24 @@ public void testToString() {
"TestDataflowRunner#TestAppName",
TestDataflowRunner.fromOptions(options).toString());
}
+ @Test
Review Comment:
(Not directly due to this PR) Running the test alone (`./gradlew
:runners:google-cloud-dataflow-java:test --tests
*testFromOptionsUsesSharedStagingLocationUnderTempRoot`) it fails with
```
java.lang.IllegalArgumentException: No filesystem found for scheme gs
at
org.apache.beam.sdk.io.FileSystems.getFileSystemInternal(FileSystems.java:558)
at
org.apache.beam.sdk.io.FileSystems.matchNewResource(FileSystems.java:665)
at
org.apache.beam.sdk.io.FileSystems.matchNewDirectory(FileSystems.java:678)
at
org.apache.beam.runners.dataflow.TestDataflowRunner.fromOptions(TestDataflowRunner.java:78)
at
org.apache.beam.runners.dataflow.TestDataflowRunnerTest.testFromOptionsUsesSharedStagingLocationUnderTempRoot(TestDataflowRunnerTest.java:108)
```
but running the test class passed. Likely a pre-existing issue though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
