goutamadwant opened a new pull request, #40331: URL: https://github.com/apache/beam/pull/40331
Fixes #25860 `FileBasedSink` currently accepts a side input for `num_shards`, then fails later while processing the pipeline. This validates `num_shards` in the constructor and raises a clear `TypeError` when it is not an `int`. The regression test covers `AsSingleton`. Before: the constructor accepts `AsSingleton` as `num_shards`. After: the constructor raises `TypeError: num_shards must be an int`. Tests: - `python -m unittest -q apache_beam.io.filebasedsink_test` — 15 passed - `python -m unittest -q apache_beam.io.textio_test` — 117 passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
